Skip to content

Add testdata utxo files with UtxoData #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Add testdata utxo files with UtxoData #444

merged 1 commit into from
Apr 21, 2025

Conversation

@JoseSK999
Copy link
Contributor

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

Description

I have pre-computed the full UtxoData vector for the two current test blocks. This way we can test every aspect of the block, including coinbase UTXOs maturity, relative timelocks, etc. This replaces the previous TxOut vectors.

We also make the UtxoData struct de/serializable.

Notes to the reviewers

I have used the UTXO fetcher CLI tool I have written for this.

Davidson-Souza
Davidson-Souza reviewed Apr 16, 2025
View reviewed changes
@Davidson-Souza Davidson-Souza added enhancement New feature or request chore Cleaning, refactoring, reducing complexity code quality Generally improves code readability and maintainability labels Apr 17, 2025
@JoseSK999 JoseSK999 force-pushed the utxo-data-test-vectors branch from aff22b1 to 9d73860 Compare April 18, 2025 16:18
@JoseSK999
Copy link
Contributor Author

JoseSK999 commented Apr 18, 2025 •
edited
Loading

I have added the test-utils feature to guard the serde derivation for UtxoData. Benches are only compiled if the feature is enabled but just bench works as an alias for the full cargo bench --features test-utils.

@JoseSK999
Add testdata utxo files with UtxoData
e03d2cf 
I have pre-computed the full `UtxoData` vector for the two current test blocks. This way we can test every aspect of the block, including coinbase UTXOs maturity, relative timelocks, etc. This replaces the previous `TxOut` vectors.

We also make the `UtxoData` struct de/serializable if the `test-utils` feature is set. This is used for benches to have the serde methods available.
@JoseSK999 JoseSK999 force-pushed the utxo-data-test-vectors branch from 9d73860 to e03d2cf Compare April 21, 2025 11:33
@JoseSK999
Copy link
Contributor Author

JoseSK999 commented Apr 21, 2025 •
edited
Loading

Added tiny nit

Davidson-Souza
Davidson-Souza approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack e03d2cf

@Davidson-Souza Davidson-Souza merged commit b2a275f into vinteumorg:master Apr 21, 2025
8 checks passed
@JoseSK999 JoseSK999 deleted the utxo-data-test-vectors branch April 22, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

Assignees

No one assigned

Labels

chore Cleaning, refactoring, reducing complexity code quality Generally improves code readability and maintainability enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoseSK999 @Davidson-Souza