CI: Check clippy on all feature combinations #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow... that was something that i didnt know that was needed. GJ! |
jaoleal
approved these changes
Apr 3, 2025
Renamed `test_features.sh` to `feature_matrix.sh`, which now can execute two actions for all features: clippy or test.
The script can be run as:
`./contrib/feature_matrix.sh {clippy|test} [cargo_arg]`
Similar to the `test-features` just recipe, I have added a `lint-features` one. Running this recipe can take more than a minute, so the regular `lint` recipe doesn't use it.
6266b2f to
020b094
Compare
|
Since running clippy for all feature combinations can take a bit of time, that is only done in the CI, in |
|
ACK 020b094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Renamed
test_features.shtofeature_matrix.sh, which now can execute two actions for all features: clippy or test.The script can be run as:
./contrib/feature_matrix.sh {clippy|test} [cargo_arg]Similar to the
test-featuresjust recipe, I have added alint-featuresone.Notes to the reviewers
You can easily verify that this works by adding any unused import that is not compiled by default. Then run
just lint-features '-- -D warnings'(to trigger an error, which we do in CI)