utils.nix and more nix flake checks #436

jaoleal · 2025-04-02T20:15:22Z

What is the purpose of this pull request?

Which crates are being modified?

Description

This PR tries to introduce new checks, a utils library for reduce the reuse of code.

Notes to the reviewers

Ready for Review update.
what ended up being changed in this PR:

utils.nix, more nix flake checks and separate checks.

Add:
        New checks (python-sanity-check, rust-sanity-check and nix-sanity-check)
        The hook that creates Environment Variables are now inside `utils.nix`.
        CI workflow for nix-related commands.
Edit:
        Packages are now offered separatelly (all, florestad, libfloresta and floresta-cli are alternatives)

removed:
        utreexod now is consumed via another flake for sake of organization.
        overlay removed

This PR introduces a need of changes on nix documentation (more context on: #429 (comment) )
but it would raise a big conflict with #429.

Ill be opening a issue to track a followup to update the documentation: #443

Checklist

I've signed all my commits (I sign after the ACK.)
I ran just lint
I ran cargo test
I've checked the integration tests
I've followed the contribution guidelines
I'm linking the issue being fixed by this PR (if any)

jaoleal · 2025-04-08T19:03:59Z

I was able to do some checks(cargo fmt) with bare nix and bash calls but looks like that im unnable to make the same with clippy. I get a strange error about internet connection even if im setting the --frozen flag when i run clippy.

Im seeing that https://github.com/cachix/git-hooks.nix?tab=readme-ov-file has managed to do clippy checks, im about to study its code and consider 2 things:

1.use git hooks itself since they have the marjority of sanity checks.
2. understand how they made clippy work inside nix checks in pure mode.

jaoleal · 2025-04-09T19:19:41Z

30e326b accomplished to add clippy and rustfmt to checks with git-hooks

jaoleal

Theres somethings that i need help to decide:

Also, Documentation is a thing... I know that most of the contributors of this project doesnt know nix and i want to make everything clear, atleast to make one have a little superficial feeling to understand whats going on here so, feel free to ask more documentation...

contrib/nix/build_floresta.nix

contrib/nix/nix_building_response_table.sh

contrib/nix/utils.nix

Davidson-Souza · 2025-04-16T21:02:23Z

After running nix develop I still need to run rustup install {stable,nightly} before using just or cargo. Is it hard to get stable and nightly installed too?

jaoleal · 2025-04-16T22:44:46Z

2bd18d6 fixes that

Davidson-Souza · 2025-04-17T14:07:37Z

Running `nix develop .#func-tests-env

error: builder for '/nix/store/7nyry4avfbjqz3dgln4mb8hxmfap465d-utreexod-0.4.1.drv' failed with exit code 1;
       last 25 log lines:
       > ok        github.com/utreexo/utreexod/btcutil     0.045s
       > ok       github.com/utreexo/utreexod/btcutil/base58      0.594s
       > ok       github.com/utreexo/utreexod/btcutil/bech32      0.004s
       > ok       github.com/utreexo/utreexod/btcutil/bloom       0.021s
       > ok       github.com/utreexo/utreexod/btcutil/coinset     0.006s
       > ok       github.com/utreexo/utreexod/btcutil/gcs 1.551s
       > ok       github.com/utreexo/utreexod/btcutil/gcs/builder 0.007s
       > ok       github.com/utreexo/utreexod/btcutil/txsort      0.004s
       > ok       github.com/utreexo/utreexod/chaincfg    0.004s
       > ok       github.com/utreexo/utreexod/chaincfg/chainhash  0.004s
       > ok       github.com/utreexo/utreexod/connmgr     0.139s
       > ok       github.com/utreexo/utreexod/database    2.561s
       > ok       github.com/utreexo/utreexod/database/ffldb      5.133s
       > ok       github.com/utreexo/utreexod/database/internal/treap     0.012s
       > --- FAIL: TestGetChainTips (11.24s)
       >     getchaintips_test.go:175: TestGetChainTips fail. Unable to setup test chain: connection timeout
       > --- FAIL: TestGetUtreexoRoots (9.53s)
       >     getutreexoroots_test.go:74: TestGetUtreexoRoots fail. Unable to setup test chain: connection timeout
       > --- FAIL: TestInvalidateAndReconsiderBlock (9.53s)
       >     invalidate_reconsider_block_test.go:17: TestInvalidateAndReconsiderBlock fail. Unable to setup test chain: connection timeout
       > --- FAIL: TestUtreexoCSN (9.53s)
       >     utreexocompactstatenode_test.go:99: TestUtreexoCSN fail. Unable to setup test chain: connection timeout
       > FAIL
       > FAIL       github.com/utreexo/utreexod/integration 39.845s
       > FAIL
       For full logs, run:
         nix log /nix/store/7nyry4avfbjqz3dgln4mb8hxmfap465d-utreexod-0.4.1.drv

jaoleal · 2025-04-17T14:35:01Z

Just updated flake.lock.

Davidson-Souza · 2025-04-22T15:09:59Z

CI is failing with:

/Users/runner/work/_temp/5d164fe5-b5c1-46cb-a45c-6efb117830b3.sh: line 2: uv: command not found

.github/workflows/nix.yml

contrib/nix/build_floresta.nix

contrib/nix/utils.nix

flake.nix

Add: New checks (python-sanity-check, rust-sanity-check and nix-sanity-check) The hook that creates Environment Variables are now inside `utils.nix`. CI workflow for nix-related commands. Edit: Packages are now offered separatelly (all, florestad, libfloresta and floresta-cli are alternatives) removed: utreexod now is consumed via another flake for sake of organization. overlay removed

jaoleal · 2025-04-30T13:31:04Z

Applied @Davidson-Souza suggestions and gpg signing

Davidson-Souza

ACK 39ed1c9

This updates the documentation related to nix in this project. fix #443

jaoleal mentioned this pull request Apr 3, 2025

[fix #428] refactor README into doc folder #429

Merged

21 tasks

jaoleal force-pushed the more-flake-checks branch 5 times, most recently from ea628ed to d579178 Compare April 8, 2025 18:59

jaoleal force-pushed the more-flake-checks branch from d579178 to 30e326b Compare April 9, 2025 19:18

jaoleal force-pushed the more-flake-checks branch 4 times, most recently from 5a76399 to fd0fe1c Compare April 11, 2025 18:58

jaoleal commented Apr 11, 2025

View reviewed changes

contrib/nix/build_floresta.nix Show resolved Hide resolved

contrib/nix/nix_building_response_table.sh Show resolved Hide resolved

contrib/nix/utils.nix Show resolved Hide resolved

jaoleal force-pushed the more-flake-checks branch 5 times, most recently from de53fab to 0b9252d Compare April 14, 2025 18:12

jaoleal marked this pull request as ready for review April 14, 2025 19:08

jaoleal mentioned this pull request Apr 14, 2025

[Followup] new nix interface for the project needs it documentation updated. #443

Closed

jaoleal force-pushed the more-flake-checks branch 2 times, most recently from d63f077 to f3f0af8 Compare April 15, 2025 16:57

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 16, 2025

Update nix docs with changes from vinteumorg#436

0d17425

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 16, 2025

Update nix docs with changes from vinteumorg#436

cd1c2b5

jaoleal mentioned this pull request Apr 16, 2025

Nix update docs #445

Merged

21 tasks

jaoleal force-pushed the more-flake-checks branch from f3f0af8 to 655cb64 Compare April 16, 2025 14:10

jaoleal force-pushed the more-flake-checks branch from 655cb64 to 2bd18d6 Compare April 16, 2025 22:43

jaoleal force-pushed the more-flake-checks branch from 2bd18d6 to 5fbcdb3 Compare April 17, 2025 14:34

Davidson-Souza added code quality Generally improves code readability and maintainability functional tests nix This change relates to the nix integration for floresta labels Apr 17, 2025

jaoleal force-pushed the more-flake-checks branch 3 times, most recently from 8b235f1 to 346ca3a Compare April 17, 2025 16:53

Davidson-Souza reviewed Apr 22, 2025

View reviewed changes

.github/workflows/nix.yml Show resolved Hide resolved

.github/workflows/nix.yml Show resolved Hide resolved

contrib/nix/build_floresta.nix Outdated Show resolved Hide resolved

contrib/nix/utils.nix Outdated Show resolved Hide resolved

flake.nix Outdated Show resolved Hide resolved

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 29, 2025

Update nix docs with changes from vinteumorg#436

4168f75

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 29, 2025

Update nix docs with changes from vinteumorg#436

53cf6e0

jaoleal force-pushed the more-flake-checks branch 2 times, most recently from 82789a3 to 247add6 Compare April 30, 2025 13:22

jaoleal force-pushed the more-flake-checks branch from 247add6 to 39ed1c9 Compare April 30, 2025 13:30

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 30, 2025

Update nix docs with changes from vinteumorg#436

2ee8111

Davidson-Souza approved these changes Apr 30, 2025

View reviewed changes

Davidson-Souza merged commit f36874d into vinteumorg:master Apr 30, 2025
10 checks passed

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 30, 2025

Update nix docs with changes from vinteumorg#436

a50ba0f

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 30, 2025

Update nix docs with changes from vinteumorg#436

8e1bfca

jaoleal added a commit to jaoleal/Floresta that referenced this pull request Apr 30, 2025

Update nix docs with changes from vinteumorg#436

3f6ebb4

Davidson-Souza pushed a commit that referenced this pull request May 1, 2025

Update nix docs with changes from #436 (#445)

b927a99

This updates the documentation related to nix in this project. fix #443

Uh oh!

utils.nix and more nix flake checks #436

utils.nix and more nix flake checks #436

Uh oh!

Conversation

jaoleal commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the purpose of this pull request?

Which crates are being modified?

Description

Notes to the reviewers

Checklist

Uh oh!

jaoleal commented Apr 8, 2025

Uh oh!

jaoleal commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaoleal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Davidson-Souza commented Apr 16, 2025

Uh oh!

jaoleal commented Apr 16, 2025

Uh oh!

Davidson-Souza commented Apr 17, 2025

Uh oh!

jaoleal commented Apr 17, 2025

Uh oh!

Davidson-Souza commented Apr 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaoleal commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Davidson-Souza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaoleal commented Apr 2, 2025 •

edited

Loading

jaoleal commented Apr 9, 2025 •

edited

Loading

jaoleal commented Apr 30, 2025 •

edited

Loading