Skip to content

Fix: description of assume utreexo was backwards #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fix: description of assume utreexo was backwards #435

merged 1 commit into from
Apr 4, 2025

Conversation

@jaoleal
Copy link
Collaborator

@jaoleal jaoleal commented Mar 31, 2025 •
edited
Loading

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

Description

#215 flipped the assume-utreexo flag but not its description.

Notes to the reviewers

didnt searched futher about other mentions of assume-utreexo that can have its meaning flipped to be in agreement of #215 changes.

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@jaoleal jaoleal force-pushed the update-assume-utreexo-description branch from 513e004 to f763a02 Compare March 31, 2025 15:03
Davidson-Souza
Davidson-Souza reviewed Mar 31, 2025
View reviewed changes
@jaoleal jaoleal force-pushed the update-assume-utreexo-description branch 4 times, most recently from 63bf9f2 to d181299 Compare March 31, 2025 19:23
@jaoleal
Copy link
Collaborator Author

jaoleal commented Mar 31, 2025

forgot to run just lint

JoseSK999
JoseSK999 suggested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is small I think we should also fix the no_backfill Cli docstring, which is also inverted.

@jaoleal jaoleal force-pushed the update-assume-utreexo-description branch from d181299 to 40b3033 Compare April 2, 2025 21:33
Davidson-Souza
Davidson-Souza approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 40b3033

@jaoleal jaoleal force-pushed the update-assume-utreexo-description branch from 40b3033 to 5c4efe5 Compare April 3, 2025 14:32
@jaoleal
Copy link
Collaborator Author

jaoleal commented Apr 3, 2025

just signed the commit.

@JoseSK999
Copy link
Contributor

It seems like you reverted the previous changes, like the no_backfill Cli docstring

@jaoleal jaoleal force-pushed the update-assume-utreexo-description branch from 5c4efe5 to ccda369 Compare April 3, 2025 15:42
@jaoleal
Copy link
Collaborator Author

jaoleal commented Apr 3, 2025

It seems like you reverted the previous changes, like the no_backfill Cli docstring

fixed

JoseSK999
JoseSK999 reviewed Apr 3, 2025
View reviewed changes
@jaoleal jaoleal force-pushed the update-assume-utreexo-description branch from ccda369 to 1a3061b Compare April 3, 2025 18:37
JoseSK999
JoseSK999 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1a3061b

Davidson-Souza
Davidson-Souza approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK 1a3061b

@Davidson-Souza Davidson-Souza merged commit 33e1d78 into vinteumorg:master Apr 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

+1 more reviewer

@JoseSK999 JoseSK999 JoseSK999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaoleal @JoseSK999 @Davidson-Souza