Skip to content

Conversation

@Davidson-Souza
Copy link
Member

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: CI updates

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: CI.

Description

Closes #415

The current CI test boostraps the fuzzer every time we run the CI due to it not using any corpus. That reduces the usefulness of running fuzz on CI. Instead of just using the fuzzer like this, we should use some corpus that already have a decent coverage and will stress our code in a satisfactory way.

This commit uses the corpus data provided by the floresta-qa-assets repository. It contains corpus data generated over months of continuous fuzzing.

Notes to the reviewers

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

The current CI test boostraps the fuzzer every time we run the CI
due to it not using any corpus. That reduces the usefulness of
running fuzz on CI. Instead of just using the fuzzer like this,
we should use some corpus that already have a decent coverage
and will stress our code in a satisfactory way.

This commit uses the corpus data provided by the floresta-qa-assets
repository. It contains corpus data generated over months of continuous
fuzzing.
@JoseSK999
Copy link
Contributor

JoseSK999 commented Mar 28, 2025

In the future we should have these inputs directly inside fuzz/corpus/ right?

Also, the utreexo_block_des fuzzing corpus has >5k entries, does it still take less than the maximum 60 seconds specified? Yeah, looking at your own branch CI job it performs 1 million runs in 60s.

Copy link
Contributor

@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c15d378

@Davidson-Souza
Copy link
Member Author

In the future we should have these inputs directly inside fuzz/corpus/ right?

I don't think we need this, since this folder can get quite big. I would download those assets only when they are need

@Davidson-Souza Davidson-Souza merged commit dbe8824 into vinteumorg:master Mar 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: use corpus for fuzzing

2 participants