Skip to content

Hotfix func test scripts #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Hotfix func test scripts #431

merged 1 commit into from
Apr 1, 2025

Conversation

@jaoleal
Copy link
Collaborator

@jaoleal jaoleal commented Mar 28, 2025 •
edited
Loading

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: bash scripts being runned by CI.

Description

Looks like that could happen a incompatibility with some bash script functionality usage and bash versions, this changes should mitigate it.

Also running prepare.sh directly to avoid problems with env vars

Notes to the reviewers

Ill use the CI scripts of this PR to validate if this fixes the problems. Nothing better than directly testing it instead of trying to reproduce it in another environment, right ?

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@jaoleal jaoleal force-pushed the hotfix-func-test-scripts branch 16 times, most recently from a65d72c to 9928420 Compare March 28, 2025 18:27
@qlrd qlrd mentioned this pull request Mar 28, 2025
Closed
@jaoleal jaoleal force-pushed the hotfix-func-test-scripts branch 11 times, most recently from d042bc6 to 37f4d81 Compare March 29, 2025 21:05
@qlrd
Copy link
Contributor

qlrd commented Mar 29, 2025

tACK 37f4d81

@qlrd qlrd mentioned this pull request Mar 31, 2025
Merged
21 tasks
@jaoleal jaoleal force-pushed the hotfix-func-test-scripts branch 2 times, most recently from 50707b5 to e357c17 Compare March 31, 2025 15:39
Davidson-Souza
Davidson-Souza requested changes Apr 1, 2025
View reviewed changes
@Davidson-Souza
Copy link
Member

This is now cloning utreexod on the working directory, rather than the test's dir. It's fine, just add utreexod to .gitignore tho

@jaoleal jaoleal force-pushed the hotfix-func-test-scripts branch from e357c17 to 24829aa Compare April 1, 2025 18:18
@jaoleal jaoleal requested a review from Davidson-Souza April 1, 2025 18:25
@jaoleal jaoleal force-pushed the hotfix-func-test-scripts branch from 24829aa to 7f37625 Compare April 1, 2025 20:56
Davidson-Souza
Davidson-Souza approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7f37625

@Davidson-Souza Davidson-Souza merged commit 961104a into vinteumorg:master Apr 1, 2025
8 checks passed
@Davidson-Souza Davidson-Souza mentioned this pull request Apr 2, 2025
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaoleal @qlrd @Davidson-Souza