Skip to content

Conversation

@luisschwab
Copy link
Contributor

@luisschwab luisschwab commented Mar 24, 2025

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: Typo fix

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other:

Description

This PR renames the function is_in_idb to is_in_ibd and capitalizes ibd on comments.

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@jaoleal
Copy link
Collaborator

jaoleal commented Mar 24, 2025

ack #43994d2

@Davidson-Souza
Copy link
Member

Davidson-Souza commented Mar 24, 2025

nice catch!

It seems like tests/floresta-cli/addnode-test.py still have the misspelled version.

@luisschwab
Copy link
Contributor Author

It seems like tests/floresta-cli/addnode-test.py still have the misspelled version.

Missed that one. Wow, windows cross-testing is taking a minute.

Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a186554

@Davidson-Souza Davidson-Souza merged commit 0b9af5c into vinteumorg:master Mar 24, 2025
8 checks passed
@luisschwab luisschwab deleted the fix/ibd-typo branch June 25, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants