Skip to content

Conversation

@nyonson
Copy link
Contributor

@nyonson nyonson commented Mar 20, 2025

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

Description

Part of the followup work in #416 for the V2 transport.

  • Log the state of transport initialization for visibility.
  • Plumb through the transport protocol version in order to expose to the user.

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@nyonson nyonson changed the title V2 p2p Transport protocol visibility Mar 20, 2025
@nyonson nyonson marked this pull request as ready for review March 20, 2025 04:15
@Davidson-Souza
Copy link
Member

For the new field inside PeerInfo you need to update the struct inside floresta-cli too. Otherwise, looks good!

@nyonson
Copy link
Contributor Author

nyonson commented Mar 24, 2025

For the new field inside PeerInfo you need to update the struct inside floresta-cli too. Otherwise, looks good!

My bad. Fixed up in d91377d and tested it locally. Didn't see it before because I wasn't able to actually test things e2e locally. I don't think related to this changeset, but once my florestad process is doing a bunch of work the getpeerinfo call times out with

Error: JsonRpc returned an error transport error: Couldn't connect to host: Resource temporarily unavailable (os error 11)

But I was able to test this change by firing a few requests before things really get going.

Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d91377d

@Davidson-Souza Davidson-Souza merged commit e4f2ba5 into vinteumorg:master Mar 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants