Add process_proof test, make it more modular
#417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to test `process_proof` without having a `ChainState` with the previous blocks, we make the function take a generic `F: Fn(u32) -> Result<BlockHash, E>`. Then for tests we pass a closure with the required hashes, and elsewhere we use `|h| self.chain.get_block_hash(h)`, instead of passing the whole `&self.chain`. We also move the `udata.proof` conversion into the `From` trait implementation. Finally reduce nesting in the `process_proof` body.
ecb64a7 to
5722817
Compare
|
Done! I have added the trait bound Then implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
In order to test
process_proofwithout having aChainStatewith the previous blocks, we make the function take a genericF: Fn(u32) -> Result<BlockHash, E>.Then for tests we pass a closure with the required hashes, and elsewhere we use
|h| self.chain.get_block_hash(h), instead of passing the whole&self.chain.We also move the
udata.proofconversion into theFromtrait implementation. Finally reduce nesting in theprocess_proofbody.Notes to the reviewers
The behavior of
process_proofshould be unchanged, I only refactored theBatchProofconversion toProof, renamedinputstoutxos,hashestodel_hashes, and reduced nesting by callingcontinue.