feat: Add listdescriptors RPC command
#407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a new RPC command `listdescriptors` to retrieve all descriptors from the wallet. - Added a method `get_descriptors` to the `AddressCache` struct to fetch descriptors. - Integrated the new RPC command into the JSON-RPC handler. - Ensured descriptors persist across node restarts by retrieving them from the wallet. This change allows users to view previously added descriptors, preventing duplicate entries when adding new descriptors.
|
@Davidson-Souza Pls review this PR |
|
Great job! One small thing missing is adding this command on the cli side inside |
|
@Davidson-Souza |
Davidson-Souza
requested changes
Mar 12, 2025
|
@Davidson-Souza Pls Review... |
|
@Davidson-Souza Pls Check again i just fix a linting error |
|
@Davidson-Souza A gentle reminder... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
This PR adds a new RPC command
listdescriptorsto Floresta, enabling users to retrieve a list of all descriptors currently being used by the node. This is particularly useful for preventing duplicate descriptor entries when adding new descriptors via theloaddescriptorcommand.Fixes: #403
Changes:
get_descriptorsto theAddressCachestruct to fetch descriptors from the wallet.listdescriptorsRPC command in theRpcImplstruct.