Update readme.md #4
Conversation
Dependency clap v4.1.4 requires rustc 1.64 or newer. For future reference, seems like the project requires Rust 2021 Edition so likely that 1.56.0 is required even if clap was removed or the requirements were lowered, the minimum would be around 1.56.0
|
I like the idea of making the MSRV explicit. The main reason why to use 2021 is because of async/await support. This node is mainly async-first, no bare threads are used, but node and electrum server run in parallel as tasks. I'll check the MSRV for async/await. Apart from that, nothing stops us from supporting older versions, I can downgrade clap or the Rust edition if possible. |
|
Ok. Is there anything specific you'd like me to do for this PR? |
|
I was checking whether |
I don't have a preference. For me it's enough that it's stated so that the user can find out why the code isn't compiling. So yeah, 2021 is ok. |
|
Ok. ACK 5926487 |
Feat: enables Home-manager.
Dependency clap v4.1.4 requires rustc 1.64 or newer.
For future reference, seems like the project requires Rust 2021 Edition so likely that 1.56.0 is required even if clap was removed or the requirements were lowered, the minimum would be around 1.56.0