Enable manual graceful shutdown #83667
Open
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
vmaineng
reviewed
Sep 10, 2025
There was a problem hiding this comment.
Hey @novascreen
Great work on this feature!
I saw there were changes to start-server.ts file and was curious if some tests should be implemented to ensure NEXT_MANUAL_SIG_HANDLE environment variable and the cleanup flow works as intended.
Please let me know what your thoughts are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19693
Enables manually triggering graceful shutdown that's handled by the
cleanupfunction instart-server.Previously we could manually handle
SIGINT/SIGTERMevents, but not trigger thecleanupthat's doing the graceful shutdown of the server. That meant we would have to abruptly kill the server or still use a custom server.