test: fix UBSan warning due to misaligned memory access in unit test_addRepliesWithOffloadsToList #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2201 +/- ##
============================================
- Coverage 71.55% 71.51% -0.04%
============================================
Files 122 122
Lines 66493 66493
============================================
- Hits 47579 47553 -26
- Misses 18914 18940 +26 🚀 New features to boost your workflow:
|
…thOffloadsToList Replaced direct cast to robj** with memcpy to avoid undefined behavior on unaligned buffers, which caused test failure when built with UBSan. Signed-off-by: xbasel <[email protected]>
zuiderkwast
approved these changes
Jun 16, 2025
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Jun 18, 2025
…addRepliesWithOffloadsToList (valkey-io#2201) Replaced direct cast to robj** with memcpy to avoid undefined behavior on unaligned buffers, which caused test failure when built with UBSan. Follow-up of valkey-io#2078 Signed-off-by: xbasel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced direct cast to robj** with memcpy to avoid undefined behavior on unaligned buffers, which caused test failure when built with UBSan.
Follow-up of #2078