Skip to content

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Oct 6, 2025

Proposed change

Make them same color. Move Snyk badge to CI/CD:

Screenshot 2025-10-06 at 4 04 27 PM Screenshot 2025-10-06 at 4 05 38 PM

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Summary by CodeRabbit

  • Documentation
    • Refreshed README badges for CI/CD and GitHub sections.
    • Updated badge color from 41BE4A to 41B5BE.
    • Added a Snyk health badge to the CI/CD badge row.
    • Removed the separate Snyk row previously listed under the GitHub section.
    • Reorganized badge placements to consolidate related badges and avoid duplication.

Walkthrough

README badges were updated: CI/CD/GitHub badge colors changed, a Snyk health badge was added to the CI/CD line, and the separate Snyk row under GitHub was removed. Badge placements in those sections were adjusted accordingly.

Changes

Cohort / File(s) Summary
Docs: README badges
README.md
- Changed badge color from 41BE4A to 41B5BE for CI/CD/GitHub badges
- Added Snyk health badge to CI/CD line
- Removed Snyk row under GitHub section
- Adjusted badge placements in CI/CD and GitHub sections

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • KJhellico
  • PPsyrius

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Update badges” directly reflects the core change of updating project badges by unifying their colors and repositioning the Snyk badge. It is concise and focused on the main element of the pull request, making it clear to anyone scanning the history. While it omits details like color unification or the specific badge move, it remains sufficiently descriptive of the primary update.
Description Check ✅ Passed The description clearly outlines the intent to unify badge colors and move the Snyk badge into the CI/CD section, supported by screenshots and a relevant change classification. It stays directly on topic by describing the specific modifications made to the README badges.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4450da8 and e2b97f6.

📒 Files selected for processing (1)
  • README.md (2 hunks)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test Python 3.13 on windows-latest
  • GitHub Check: Test Python 3.14 on windows-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4450da8) to head (e2b97f6).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2990   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       305           
  Lines        17996     17996           
  Branches      2321      2321           
=========================================
  Hits         17996     17996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkid15r arkid15r marked this pull request as ready for review October 6, 2025 23:12
@arkid15r arkid15r enabled auto-merge October 6, 2025 23:12
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎨

@arkid15r arkid15r added this pull request to the merge queue Oct 7, 2025
Merged via the queue into vacanza:dev with commit 38f1da7 Oct 7, 2025
36 checks passed
@arkid15r arkid15r deleted the ark/unify-badge-colors branch October 7, 2025 00:13
@KJhellico KJhellico mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants