-
-
Notifications
You must be signed in to change notification settings - Fork 560
Update Brazil holidays: Republic Constitution Day typo fixed #2933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughCorrects a diacritic in Brazil’s Republic Constitution Day name to “Constituição da República” in the holiday definition, updates corresponding locale PO files (en_US, pt_BR, uk) and adjusts tests. PO headers (project version, revision date, generator) were refreshed; no control flow or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (15)📚 Learning: 2025-06-28T10:39:19.185ZApplied to files:
📚 Learning: 2025-03-31T19:37:57.691ZApplied to files:
📚 Learning: 2025-06-26T15:34:35.476ZApplied to files:
📚 Learning: 2025-03-31T19:37:57.691ZApplied to files:
📚 Learning: 2025-06-29T09:37:35.283ZApplied to files:
📚 Learning: 2025-05-10T04:02:13.815ZApplied to files:
📚 Learning: 2025-05-06T15:25:44.333ZApplied to files:
📚 Learning: 2025-03-30T18:25:07.087ZApplied to files:
📚 Learning: 2025-06-11T18:32:25.595ZApplied to files:
📚 Learning: 2025-03-05T17:51:00.633ZApplied to files:
📚 Learning: 2025-09-17T15:53:16.940ZApplied to files:
📚 Learning: 2025-04-03T05:59:57.480ZApplied to files:
📚 Learning: 2025-04-26T19:55:09.581ZApplied to files:
📚 Learning: 2025-06-19T05:54:49.792ZApplied to files:
📚 Learning: 2025-06-10T12:17:58.880ZApplied to files:
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2933 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 296 296
Lines 17616 17616
Branches 2269 2269
=========================================
Hits 17616 17616 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|



Proposed change
This is part of the non-test case changes decoupling from #2881
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.