-
-
Notifications
You must be signed in to change notification settings - Fork 560
Refactor Japan holidays: reduce l10n string duplication, en_US typo fixed
#2937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughUnifies Emperor’s Birthday, Showa Day, and Greenery Day logic in Japan holidays. Updates English, Japanese, and Thai PO metadata and reorders Greenery Day entries. Renames “Autumnal Equinox” to “Autumnal Equinox Day” across en_US PO, snapshots, and a test expectation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (6)
🧰 Additional context used🧠 Learnings (15)📚 Learning: 2025-06-26T15:34:35.476ZApplied to files:
📚 Learning: 2025-06-28T10:39:19.185ZApplied to files:
📚 Learning: 2025-06-29T09:37:35.283ZApplied to files:
📚 Learning: 2025-05-06T15:25:44.333ZApplied to files:
📚 Learning: 2025-03-05T17:51:00.633ZApplied to files:
📚 Learning: 2025-05-10T04:02:13.815ZApplied to files:
📚 Learning: 2025-06-25T10:09:29.029ZApplied to files:
📚 Learning: 2025-06-11T18:32:25.595ZApplied to files:
📚 Learning: 2025-03-30T18:25:07.087ZApplied to files:
📚 Learning: 2025-03-08T11:28:48.652ZApplied to files:
📚 Learning: 2025-05-10T04:32:15.760ZApplied to files:
📚 Learning: 2025-05-10T04:34:02.406ZApplied to files:
📚 Learning: 2025-08-21T04:56:03.780ZApplied to files:
📚 Learning: 2025-08-28T02:34:11.657ZApplied to files:
📚 Learning: 2025-03-19T16:54:58.657ZApplied to files:
🧬 Code graph analysis (1)holidays/countries/japan.py (1)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (12)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Ruff (0.12.2)holidays/countries/japan.py�[1;31mruff failed�[0m tests/countries/test_japan.py�[1;31mruff failed�[0m Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2937 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 296 296
Lines 17596 17597 +1
Branches 2270 2270
=========================================
+ Hits 17596 17597 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



Proposed change
en_USl10n from "Autumnal Equinox" to "Autumnal Equinox Day"This is part of the non-test case changes decoupling from #2881
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.