-
-
Couldn't load subscription status.
- Fork 560
Update Singapore holidays: remove duplicate holidays label assignment #2844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughAdds two label attributes to Singapore holidays. Updates en_SG, en_US, and th SG.po metadata and adds new “estimated” and “observed, estimated” strings (with Thai translations). Standardizes SG snapshot labels to “observed, estimated” and removes one Eid al-Fitr entry on 2030-02-04. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (22)📚 Learning: 2025-06-28T10:39:19.185ZApplied to files:
📚 Learning: 2025-05-06T15:25:44.333ZApplied to files:
📚 Learning: 2025-06-26T15:34:35.476ZApplied to files:
📚 Learning: 2025-03-05T17:51:00.633ZApplied to files:
📚 Learning: 2025-03-30T18:25:07.087ZApplied to files:
📚 Learning: 2025-03-08T11:28:48.652ZApplied to files:
📚 Learning: 2025-06-11T18:32:25.595ZApplied to files:
📚 Learning: 2025-06-29T09:37:35.283ZApplied to files:
📚 Learning: 2025-06-25T20:55:00.642ZApplied to files:
📚 Learning: 2025-08-19T20:04:26.215ZApplied to files:
📚 Learning: 2025-06-25T10:09:29.029ZApplied to files:
📚 Learning: 2025-05-10T04:02:13.815ZApplied to files:
📚 Learning: 2025-06-25T10:12:30.448ZApplied to files:
📚 Learning: 2025-08-21T04:51:16.392ZApplied to files:
📚 Learning: 2025-08-21T04:56:03.711ZApplied to files:
📚 Learning: 2025-08-21T04:56:03.711ZApplied to files:
📚 Learning: 2025-06-26T13:20:10.172ZApplied to files:
📚 Learning: 2025-04-03T05:59:57.480ZApplied to files:
📚 Learning: 2025-03-19T16:54:58.657ZApplied to files:
📚 Learning: 2025-03-19T16:53:00.375ZApplied to files:
📚 Learning: 2025-04-13T19:10:31.502ZApplied to files:
📚 Learning: 2025-04-13T20:41:56.613ZApplied to files:
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (8)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2844 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 286 286
Lines 17038 17040 +2
Branches 2229 2229
=========================================
+ Hits 17038 17040 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍



Proposed change
Remove duplicate holidays label assignment for Singapore as done elsewhere library-wide i.e.
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.