Update Indonesia holidays: add August 18, 2025 holiday #2773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by CodeRabbit
WalkthroughA new translation constant for Indonesia's Independence Day Joint Holiday was introduced and used in the holiday definitions. The 2025 holiday data and corresponding tests were updated to include August 18, 2025, as an official joint holiday. Documentation was also updated with a new reference URL. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested labels
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (40)📓 Common learnings📚 Learning: in the holidays project, test methods for country holidays follow a standard form where year ranges ...Applied to files:
📚 Learning: in the guinea holidays implementation, observed eid al-fitr cases are properly covered by the test_e...Applied to files:
📚 Learning: in the holidays project, test files follow a dual testing approach: individual methods test specific...Applied to files:
📚 Learning: in the guinea holidays implementation, observed eid al-fitr cases are covered by the test_eid_al_fit...Applied to files:
📚 Learning: for holiday tests in the vacanza/holidays project, structure tests by individual holidays rather tha...Applied to files:
📚 Learning: references in holidays classes should only be included if they're used for test case cross-checks or...Applied to files:
📚 Learning: in the saint vincent and the grenadines holidays implementation, new year's day is added without obs...Applied to files:
📚 Learning: in christmas island's holiday implementation, the test_christmas_day method cannot use assertnononob...Applied to files:
📚 Learning: in the holidays project test files, the standard method name for testing the absence of holidays is ...Applied to files:
📚 Learning: in the holidays library implementation, explicit holiday dates (like diwali in fiji) are only define...Applied to files:
📚 Learning: in the holidays project, snapshot files (like snapshots/countries/tl_common.json) are auto-generated...Applied to files:
📚 Learning: in the fiji holidays implementation, the maintainers are aware of the need to extend the mawlid_date...Applied to files:
📚 Learning: snapshot files in the holidays library (like those in snapshots/countries/) are generated automatica...Applied to files:
📚 Learning: in the fiji holidays implementation, the `special_public_holidays_observed` dictionary in `fijistati...Applied to files:
📚 Learning: custom holiday classes that extend _customhinduholidays, _customislamicholidays, _custombuddhistholi...Applied to files:
📚 Learning: for holiday definitions in the holidays package, keep comments simple with just the holiday name (e....Applied to files:
📚 Learning: second republic day in guinea was abolished by at least 2022 according to decree d/2022/0526/prg/cnr...Applied to files:
📚 Learning: in namibia's holiday system, genocide remembrance day (may 28, starting 2025) is implemented as a fi...Applied to files:
📚 Learning: for islamic holidays in guinea like "lendemain de la nuit lailatoul qadr" (day after night of power)...Applied to files:
📚 Learning: for islamic holidays in guinea like "lendemain de la nuit lailatoul qadr" (day after night of power)...Applied to files:
📚 Learning: in the holidays library, the ramadan_beginning_dates dictionary in country-specific islamic holiday ...Applied to files:
📚 Learning: the islamic holiday dates in the holidays library should only include officially verified dates, not...Applied to files:
📚 Learning: the `_customislamicholidays` classes in this project contain only exact verified holiday dates from ...Applied to files:
📚 Learning: in the holidays package, detailed historical context and additional information should be added as c...Applied to files:
📚 Learning: library-wide holiday patterns and their optimizations should be handled at the base class level (lik...Applied to files:
📚 Learning: in the france holidays implementation, legislative years for holiday changes should be hard-coded ra...Applied to files:
📚 Learning: the ivorycoast class in holidays/countries/ivory_coast.py already includes documentation in its clas...Applied to files:
📚 Learning: antigua and barbuda has had only two general elections (2018 and 2023) since the 2014 amendment that...Applied to files:
📚 Learning: in the holidays library, date dictionaries that map years to specific dates (like queens_birthday_da...Applied to files:
📚 Learning: in guyana's holidays implementation (holidays/countries/guyana.py), emancipation day should be imple...Applied to files:
📚 Learning: holiday name comments directly above tr() function calls in the holidays package should only contain...Applied to files:
📚 Learning: in the holidays library, the standard approach for organizing static holidays is to use separate dic...Applied to files:
📚 Learning: in the holidays library, the standard approach for organizing static holidays is to use separate dic...Applied to files:
📚 Learning: the en_tl (english for timor-leste) localization for holidays intentionally uses "world" instead of ...Applied to files:
📚 Learning: in the holidays library, `_customislamicholidays` subclasses follow a consistent pattern of not havi...Applied to files:
📚 Learning: the holidays library provides helper methods `_add_holiday_2nd_sun_of_may()` and `_add_holiday_3rd_s...Applied to files:
📚 Learning: in the holidays library, method names like `_add_holiday_2nd_tue_of_feb()` and `_add_holiday_1st_sun...Applied to files:
📚 Learning: in christmas island, anzac day (april 25) follows the same observed holiday rules as other holidays,...Applied to files:
📚 Learning: territorial holiday classes that inherit from parent countries (like holidaysax from finland, holida...Applied to files:
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (6)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2773 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 272 272
Lines 16240 16241 +1
Branches 2191 2191
=========================================
+ Hits 16240 16241 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update Indonesia holidays: add August 18, 2025 holiday (Independence Day Joint Holiday).
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.