Update Thailand holidays: add uk localization #2566

KJhellico · 2025-05-25T21:08:29Z

Proposed change

Update Thailand holidays: add uk localization. I also updated the transcription of King Ramkhamhaeng's name (it seems to be more correct).

@PPsyrius, I finally did it! ✌️

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-05-25T21:08:36Z

Summary by CodeRabbit

New Features
- Added Ukrainian language support for Thailand holidays, including comprehensive Ukrainian translations for all major Thai holidays.
Bug Fixes
- Corrected the spelling of "Ramkhamhaeng" in holiday names and comments across relevant localizations and documentation.
Documentation
- Updated the README to include Ukrainian as a supported language for Thailand.
Tests
- Added tests to verify Ukrainian holiday localizations for Thailand.

Walkthrough

The update introduces Ukrainian ("uk") localization support for Thailand holidays, correcting previous typos in "Ramkhamhaeng" across documentation, code, and translations. It adds a Ukrainian translation file, updates supported languages in both code and documentation, and expands test coverage to verify Ukrainian holiday names.

Changes

Files/Paths	Change Summary
README.md	Added "uk" to Thailand's supported languages list in documentation.
holidays/countries/thailand.py	Added "uk" to supported languages; fixed spelling of "Ramkhamhaeng" in comments.
holidays/locale/en_US/LC_MESSAGES/TH.po holidays/locale/th/LC_MESSAGES/TH.po	Fixed spelling of "Ramkhamhaeng" in comments and translation strings.
holidays/locale/uk/LC_MESSAGES/TH.po	Added new Ukrainian localization file for Thailand holidays.
tests/countries/test_thailand.py	Added Ukrainian localization tests; fixed "Ramkhamhaeng" typo in English localization test.

Suggested labels

l10n, test

Suggested reviewers

PPsyrius

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between caf06b0 and 7709547.

📒 Files selected for processing (6)

README.md (1 hunks)
holidays/countries/thailand.py (2 hunks)
holidays/locale/en_US/LC_MESSAGES/TH.po (1 hunks)
holidays/locale/th/LC_MESSAGES/TH.po (1 hunks)
holidays/locale/uk/LC_MESSAGES/TH.po (1 hunks)
tests/countries/test_thailand.py (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/countries/test_thailand.py (1)

tests/common.py (1)

assertLocalizedHolidays (327-338)

🔇 Additional comments (8)

holidays/locale/th/LC_MESSAGES/TH.po (1)

318-320: Spelling consistency for “Ramkhamhaeng” in Thai locale
The transliteration comment has been updated to match the corrected spelling of Ramkhamhaeng across other locales. Nice catch on the typo.

holidays/locale/en_US/LC_MESSAGES/TH.po (1)

318-321: Typo fix for “Ramkhamhaeng” in English locale
The English localization now reflects the accurate spelling in both the comment and translation string, keeping it consistent with the country implementation.

README.md (1)

1237-1241: Documented Ukrainian support for Thailand
The supported_languages entry for TH now includes uk, matching the implementation and new locale file. Documentation and code are in sync.

holidays/countries/thailand.py (2)

189-191: Add Ukrainian to supported_languages
Extending supported_languages to include "uk" aligns perfectly with the new Ukrainian localization and tests.

933-937: Correct transliteration in holiday population
The comment and method call for King Ramkhamhaeng Memorial Day now use the accurate spelling, consistent with locale files.

tests/countries/test_thailand.py (2)

862-862: Good catch on the spelling correction!

The fix from "Ramkamhaeng" to "Ramkhamhaeng" aligns with the more accurate transcription mentioned in the PR objectives.

908-959: Comprehensive Ukrainian localization test implementation.

The new test_l10n_uk method properly follows the established pattern and covers all Thailand holidays for 2022. The Ukrainian translations appear well-formatted and the test structure is consistent with the existing English localization test.

holidays/locale/uk/LC_MESSAGES/TH.po (1)

1-342: Excellent Ukrainian localization implementation.

This comprehensive .po file properly implements Ukrainian translations for Thailand holidays. The structure follows gettext standards, includes all necessary metadata, and provides complete coverage of Thai holidays including national holidays, royal ceremonies, religious festivals, and special observances. The UTF-8 encoding correctly supports Ukrainian characters.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-05-25T21:10:05Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-05-25T21:10:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (caf06b0) to head (7709547).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2566   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          221       221           
  Lines        14134     14134           
  Branches      1983      1983           
=========================================
  Hits         14134     14134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius

LGTM 🙏

holidays/countries/thailand.py

arkid15r

LGTM 🇺🇦

Update Thailand holidays: add uk localization

7709547

KJhellico requested review from PPsyrius and arkid15r as code owners May 25, 2025 21:08

github-actions bot added l10n test labels May 25, 2025

PPsyrius approved these changes May 25, 2025

View reviewed changes

holidays/countries/thailand.py Show resolved Hide resolved

arkid15r reviewed May 27, 2025

View reviewed changes

arkid15r added this pull request to the merge queue May 27, 2025

Merged via the queue into vacanza:dev with commit d395877 May 27, 2025
33 checks passed

KJhellico deleted the loc-thailand-uk branch May 27, 2025 09:26

arkid15r mentioned this pull request Jun 2, 2025

v0.74 #2586

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update Thailand holidays: add uk localization #2566

Update Thailand holidays: add uk localization #2566

Uh oh!

KJhellico commented May 25, 2025

Uh oh!

coderabbitai bot commented May 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented May 25, 2025

Uh oh!

codecov bot commented May 25, 2025 •

edited

Loading

Uh oh!

PPsyrius left a comment

Uh oh!

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Update Thailand holidays: add uk localization #2566

Update Thailand holidays: add uk localization #2566

Uh oh!

Conversation

KJhellico commented May 25, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented May 25, 2025

Quality Gate passed

Uh oh!

codecov bot commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented May 25, 2025 •

edited

Loading

codecov bot commented May 25, 2025 •

edited

Loading