Update pre-commit config #2548

KJhellico · 2025-05-16T11:36:28Z

Proposed change

Update pre-commit config:

replace bandit hook with flake8-bandit
remove excessive mypy additional dependencies

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

…dit`

coderabbitai · 2025-05-16T11:36:35Z

Summary by CodeRabbit

Chores
- Updated pre-commit configuration, including renaming and removal of certain hooks and dependencies.
- Modified linter and security scanner settings for improved consistency and maintenance.
Style
- Removed specific type annotations and comments in the Malaysia holidays module for cleaner code.

Summary by CodeRabbit

Chores
- Updated pre-commit configuration, including renaming a linting hook and removing the Bandit security scanner.
- Adjusted project settings to remove Bandit configuration and update linting rules for better control over security checks in test files.
- Cleaned up type annotations and comments in the Malaysia holiday country module.

Walkthrough

The updates remove Bandit security scanning from both the pre-commit configuration and the project settings. Ruff linter configuration is adjusted to include security checks and to ignore them in test files. The Ruff pre-commit hook is renamed, and configuration for per-file ignores is updated for clarity and scope. Additionally, type annotations and explanatory comments were removed from the Malaysia holiday module without changing functionality.

Changes

File(s)	Change Summary
.pre-commit-config.yaml	Removed Bandit hook; renamed Ruff hook from `ruff` to `ruff-check`; kept Ruff formatting hook unchanged.
pyproject.toml	Deleted `[tool.bandit]` section; added "S" codes to Ruff `select`; renamed per-file ignores key; ignored "S" in tests; preserved existing ignore for `scripts/generate_release_notes.py`.
holidays/countries/malaysia.py	Removed conditional import of `date` for type checking; deleted type annotation and explanatory comment for `dts_observed` in `Malaysia` class.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch upd-pre-commit-cfg
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-05-16T11:38:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ed09644) to head (5d951ba).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          216       216           
  Lines        13739     13737    -2     
  Branches      1942      1942           
=========================================
- Hits         13739     13737    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between ed09644 and 3501d52.

📒 Files selected for processing (2)

.pre-commit-config.yaml (1 hunks)
pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 300000ms (1)

GitHub Check: Test build on windows-latest

🔇 Additional comments (1)

pyproject.toml (1)

70-70: Enable Ruff security checks by including “S” codes
Adding the “S” category to select ensures Ruff will pick up the Bandit‐style security rules via flake8-bandit. This aligns perfectly with the goal of replacing the old Bandit hook.

pyproject.toml

.pre-commit-config.yaml

PPsyrius

LGTM - great work on test suite consolidation 👍

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

pyproject.toml (1)

72-72: Rename to per-file-ignores.

Switching from extend-per-file-ignores to the documented per-file-ignores format is correct and aligns with Ruff’s latest configuration style.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 48e9a42 and dd09aa6.

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

🔇 Additional comments (1)

pyproject.toml (1)

70-70: Include security checks in Ruff select.

Adding "S" to the select list ensures Ruff continues to enforce security rules now that Bandit is removed.

pyproject.toml

sonarqubecloud · 2025-05-18T18:28:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

pyproject.toml (1)

72-72: Rename per-file-ignores as intended
The switch from extend-per-file-ignores to per-file-ignores correctly follows Ruff’s configuration conventions.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between dd09aa6 and 5d951ba.

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 300000ms (1)

GitHub Check: Test build on windows-latest

🔇 Additional comments (1)

pyproject.toml (1)

70-70: Include security rule codes in Ruff linting
Adding "S" to the select list ensures Ruff will check security-related rules via the flake8-bandit integration. This aligns with replacing the Bandit hook in pre-commit.

pyproject.toml

arkid15r

LGTM 👍

Co-authored-by: Arkadii Yakovets <[email protected]>

Update pre-commit config: replace bandit with `ruff.lint.flake8-ban…

3501d52

…dit`

KJhellico requested review from PPsyrius and arkid15r as code owners May 16, 2025 11:36

coderabbitai bot reviewed May 16, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

.pre-commit-config.yaml Show resolved Hide resolved

Simplify Malaysia observed holidays handling

48e9a42

KJhellico changed the title ~~Update pre-commit config: replace bandit with ruff.lint.flake8-bandit~~ Update pre-commit config May 16, 2025

PPsyrius previously approved these changes May 16, 2025

View reviewed changes

Update code

dd09aa6

arkid15r dismissed PPsyrius’s stale review via dd09aa6 May 18, 2025 18:17

coderabbitai bot reviewed May 18, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Narrow down per file ignores for tests

5d951ba

arkid15r enabled auto-merge May 18, 2025 18:24

coderabbitai bot reviewed May 18, 2025

View reviewed changes

pyproject.toml Show resolved Hide resolved

arkid15r approved these changes May 18, 2025

View reviewed changes

arkid15r added this pull request to the merge queue May 18, 2025

Merged via the queue into vacanza:dev with commit cf52064 May 18, 2025
33 checks passed

KJhellico deleted the upd-pre-commit-cfg branch May 18, 2025 20:26

KJhellico mentioned this pull request May 19, 2025

v0.73 #2553

Merged

Wasif-Shahzad pushed a commit to Wasif-Shahzad/holidays that referenced this pull request May 21, 2025

Update pre-commit config (vacanza#2548)

91898a0

Co-authored-by: Arkadii Yakovets <[email protected]>

ShalomDee pushed a commit to ShalomDee/holidays that referenced this pull request Jun 2, 2025

Update pre-commit config (vacanza#2548)

5be35cc

Co-authored-by: Arkadii Yakovets <[email protected]>

Uh oh!

Update pre-commit config #2548

Update pre-commit config #2548

Uh oh!

Conversation

KJhellico commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented May 18, 2025

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KJhellico commented May 16, 2025 •

edited

Loading

coderabbitai bot commented May 16, 2025 •

edited

Loading

codecov bot commented May 16, 2025 •

edited

Loading