Skip to content

Introduce HolidayBase methods for proper serialization #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 4 commits into from
Mar 9, 2025
Merged

Introduce HolidayBase methods for proper serialization #2333

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b3eb72
Introduce HolidayBase methods for proper serialization
KJhellico Mar 6, 2025
9658a5f
Update test
KJhellico Mar 6, 2025
9ef839a
Fix key removing
KJhellico Mar 6, 2025
eaa6a31
Apply suggestions from code review
KJhellico Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test
  • Loading branch information
@KJhellico
KJhellico committed Mar 6, 2025
commit 9658a5f6acdee9845d502f0f9fb54716ec2fb05f
13 changes: 7 additions & 6 deletions tests/test_holiday_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,13 +868,14 @@ def test_pickle(self):
self.assertIn(dt, self.hb)

def test_pickle_localized_entity(self):
ua = UA(language="uk")
dt = "2021-01-01"
self.assertIn(dt, self.hb)
for lang in ("uk", "en_US", None):
ua = UA(language=lang)
dt = "2021-01-01"
self.assertIn(dt, self.hb)

loaded_ua = pickle.loads(pickle.dumps(ua))
self.assertEqual(loaded_ua, ua)
self.assertIn(dt, loaded_ua)
loaded_ua = pickle.loads(pickle.dumps(ua))
self.assertEqual(loaded_ua, ua)
self.assertIn(dt, loaded_ua)


class TestSpecialHolidays(unittest.TestCase):
Expand Down