Skip to content

Fix 2025 Chinese Calendar's Birthday of Buddha #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2025
Merged

Fix 2025 Chinese Calendar's Birthday of Buddha #2310

merged 5 commits into from
Feb 25, 2025

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Feb 25, 2025

Proposed change

Fixed the wrong pre-calculated results for the 2025 Chinese Calendar-based "Birthday of Buddha" - this should've been on MAY, 5 instead of MAY, 4 as confirmed by Hong Kong's, South Korea's and Macao's calendar - the only 3 entities that observes them as holidays at the moment.

I came across this by chance while sorting out test case errors for my WIP Macao implementation, and I'm surprised this wasn't spotted in our recent HK l10n implementation.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (93fb2d7) to head (57353d1).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          201       201           
  Lines        12340     12340           
  Branches      1771      1771           
=========================================
  Hits         12340     12340

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Feb 25, 2025

Sorry for the multiple commits, the test keeps failing due to artifacts from local Macao branch so make check is more or less unusable on my end at the moment 😔

@KJhellico
Copy link
Collaborator

KJhellico commented Feb 25, 2025

@PPsyrius, good catch! Indeed, the new moon is April 28, so 8th day of 4th lunar month is May 5. And this is both in the Korean and Chinese time zones. It looks like the source of our Chinese calendar needs to be checked in more detail...

KJhellico
KJhellico approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

arkid15r
arkid15r approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Feb 25, 2025
Merged via the queue into vacanza:dev with commit 13e3c47 Feb 25, 2025
32 checks passed
@PPsyrius PPsyrius deleted the 2025_cn_buddha branch February 27, 2025 04:29
@arkid15r arkid15r mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @KJhellico @arkid15r