Skip to content

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update some holidays Ukrainian translations (Victory Day, Independence Day etc).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2025

@codecov
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f5475cb) to head (cb152f8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          199       199           
  Lines        12134     12134           
  Branches      1731      1731           
=========================================
  Hits         12134     12134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇺🇦

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇺🇦 LGTM

@arkid15r arkid15r added this pull request to the merge queue Feb 3, 2025
Merged via the queue into vacanza:dev with commit 19f488a Feb 3, 2025
32 checks passed
@KJhellico KJhellico deleted the upd-l10n-uk branch February 3, 2025 10:27
@arkid15r arkid15r mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants