Skip to content

Update Iran holidays #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2025
Merged

Update Iran holidays #2234

merged 5 commits into from
Jan 23, 2025

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update Iran holidays:

  • set exact dates of Islamic holidays in 2001-2025
  • update Farsi and English holidays names
  • replace fa locale with fa_IR

Closes #2229.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7566884) to head (c5f1a06).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11852     11876   +24     
  Branches      1712      1713    +1     
=========================================
+ Hits         11852     11876   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico KJhellico mentioned this pull request Jan 21, 2025
Closed
PPsyrius
PPsyrius previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇮🇷

arkid15r
arkid15r reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r enabled auto-merge January 23, 2025 02:15
PPsyrius
PPsyrius previously approved these changes Jan 23, 2025
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arkid15r arkid15r added this pull request to the merge queue Jan 23, 2025
Merged via the queue into vacanza:dev with commit 4c678d1 Jan 23, 2025
32 checks passed
@KJhellico KJhellico deleted the upd-iran branch January 23, 2025 20:30
@arkid15r arkid15r mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@PPsyrius PPsyrius PPsyrius left review comments

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Dates for Islamic Holidays in Iranian Calendar

3 participants

@KJhellico @arkid15r @PPsyrius