Skip to content

Add HebrewCalendarHolidays to holidays groups, refactor Israel holidays #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2024
Merged

Add HebrewCalendarHolidays to holidays groups, refactor Israel holidays #2186

merged 3 commits into from
Dec 24, 2024

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Add HebrewCalendarHolidays to holidays groups (for use in other countries with Hebrew holidays); refactor Israel holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (43f3f2c) to head (f140153).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       195    +1     
  Lines        11657     11679   +22     
  Branches      1691      1685    -6     
=========================================
+ Hits         11657     11679   +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkid15r
arkid15r reviewed Dec 22, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this refactoring is long overdue. Thanks for addressing it!

arkid15r
arkid15r reviewed Dec 22, 2024
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius
PPsyrius approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arkid15r
arkid15r reviewed Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping it well-structured.

@arkid15r arkid15r enabled auto-merge December 24, 2024 03:11
@arkid15r arkid15r added this pull request to the merge queue Dec 24, 2024
Merged via the queue into vacanza:dev with commit e92a949 Dec 24, 2024
30 checks passed
@KJhellico KJhellico deleted the upd-israel branch December 24, 2024 15:01
@arkid15r arkid15r mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius