Skip to content

Update Argentina holidays: Add 2025 Bridge Public Holidays #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update Argentina holidays: Add 2025 Bridge Public Holidays #2146

merged 1 commit into from
Nov 28, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Nov 27, 2024

Proposed change

Add 2025 Bridge Public Holidays for Argentina as done in Decreto 1017/2024.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2922431) to head (9777eea).
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       194           
  Lines        11716     11716           
  Branches      1771      1771           
=========================================
  Hits         11716     11716

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KJhellico KJhellico changed the title Update Argentia holidays: Add 2025 Bridge Public Holidays Update Argentina holidays: Add 2025 Bridge Public Holidays Nov 27, 2024
arkid15r
arkid15r reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@arkid15r arkid15r added this pull request to the merge queue Nov 28, 2024
Merged via the queue into vacanza:dev with commit 44e5cb8 Nov 28, 2024
28 checks passed
@PPsyrius PPsyrius deleted the arg_2025 branch November 28, 2024 05:05
@arkid15r arkid15r mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico