Skip to content

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Nov 9, 2024

Proposed change

Update helpers::_normalize_arguments, add helpers tests

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2024

@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4fcbc7) to head (9bd7c98).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11590     11590           
  Branches      1747      1747           
=========================================
  Hits         11590     11590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Nov 9, 2024
Merged via the queue into vacanza:dev with commit 74efb53 Nov 9, 2024
29 checks passed
@arkid15r arkid15r deleted the update-normalize-arguments-helper branch November 9, 2024 20:54
@KJhellico KJhellico mentioned this pull request Nov 18, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants