Skip to content

Update Brazil holidays, add l10n support #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2024
Merged

Update Brazil holidays, add l10n support #2113

merged 6 commits into from
Nov 11, 2024

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

  • Update Brazil holidays
  • add l10n support (en_US, pt_BR, uk)
  • add subdivision aliases
  • update tests

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4fcbc7) to head (a2e884f).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11590     11599    +9     
  Branches      1747      1749    +2     
=========================================
+ Hits         11590     11599    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico KJhellico mentioned this pull request Nov 7, 2024
Merged
9 tasks
PPsyrius
PPsyrius reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, the last major nation without en_US support is getting one 👍

@KJhellico
Copy link
Collaborator Author

Finally, the last major nation without en_US support is getting one 👍

There's still Italy to update. ;)

@PPsyrius PPsyrius mentioned this pull request Nov 8, 2024
Merged
9 tasks
PPsyrius
PPsyrius previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇧🇷

arkid15r
arkid15r previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

LGTM

@KJhellico KJhellico dismissed stale reviews from arkid15r and PPsyrius via a2e884f November 11, 2024 17:15
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge November 11, 2024 17:27
@arkid15r
Copy link
Collaborator

@araggohnxd thanks for reviewing this!
I believe everything looks good to you as a native Portuguese speaker?

arkid15r
arkid15r approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's fix those later (if any)

@arkid15r arkid15r added this pull request to the merge queue Nov 11, 2024
Merged via the queue into vacanza:dev with commit f9851fa Nov 11, 2024
29 checks passed
@KJhellico KJhellico deleted the loc-brazil branch November 11, 2024 19:32
@KJhellico KJhellico mentioned this pull request Nov 18, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@KJhellico @mstuttgart
Update Brazil holidays, add l10n support (vacanza#2113)
557c58b
@arkid15r arkid15r mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@PPsyrius PPsyrius PPsyrius left review comments

+1 more reviewer

@araggohnxd araggohnxd araggohnxd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KJhellico @arkid15r @PPsyrius @araggohnxd