Skip to content

Update Indonesia holidays: th localization, more refractor #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2024
Merged

Update Indonesia holidays: th localization, more refractor #2097

merged 3 commits into from
Nov 1, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 31, 2024 •
edited
Loading

Proposed change

  • Add Thai (th) localization for Indonesia holidays.
  • Update National and Joint Holiday ("Cuti Bersama"; government category) assignment up to 2025 as last decreed on Oct 14, 2024.
  • Sort all National Holidays assignments as per their last decreed date. Lunar New Year holidays are now only assigned for 2003 onwards as I cannot find their usage pre-1967 as mentioned in the previous implementation.
  • Add in future Nyepi dates up to 2030.
  • Add in all historical election dates as of October 2024 (1999-2024).
  • Add in all joint holiday dates as of October 2024 (2002-2025).

@KJhellico as there are some new Ukrainian l10n entries, some double-checking are needed here. :)

Note

There's some Denominative-based holidays in-use between 15 October, 1963 - 16 December, 1967 that could be implemented as well as per listed in [1] [2] which goes as follows:

Muslims

  1. Tahun Baru Hijriyah
  2. Asjura
  3. Maulid Nabi
  4. Isra Mikraj
  5. Nisfu Sja'ban
  6. 1 Ramadhan
  7. Nuzulul Quran

Christians (Protestants)

  1. Hari Kedua Natal
  2. Jumat Agung
  3. Hari Senin Paskah
  4. Kenaikan Isa Almasih

Catholics

  1. Hari Kedua Natal
  2. Hari Senin Paskah
  3. Kenaikan Isa Almasih
  4. Hari Santa Maria

Balinese Hinduism

Which has a maximum of four days in total. Date assignments are determined by the Governor of the Level I Regional Head of Bali with the approval of the Minister of Religion.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0ae7f41) to head (d11c5a7).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2097   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines        11537     11549   +12     
  Branches      1738      1736    -2     
=========================================
+ Hits         11537     11549   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great work! Just few fixes in Ukrainian :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@PPsyrius PPsyrius requested a review from KJhellico November 1, 2024 01:28
arkid15r
arkid15r reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM

@arkid15r arkid15r enabled auto-merge November 1, 2024 15:51
@arkid15r arkid15r added this pull request to the merge queue Nov 1, 2024
Merged via the queue into vacanza:dev with commit ca990d6 Nov 1, 2024
29 checks passed
@PPsyrius PPsyrius deleted the indonesia_th_l10n branch November 1, 2024 17:23
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@PPsyrius @KJhellico @mstuttgart
Update Indonesia holidays: th localization, more refractor (vacanza…
d92687d 
…#2097)

Co-authored-by: ~Jhellico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico