Skip to content

Satisfy mypy requirements #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

Satisfy mypy requirements #2053

merged 2 commits into from
Oct 17, 2024

Conversation

@arkid15r
Copy link
Collaborator

Proposed change

Based on https://github.com/vacanza/holidays/actions/runs/11356900938
I'm not really sure if it's the best way to address it. Feel free to suggest better options if you see any.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ad44b7c) to head (f64af5e).
Report is 5 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2053   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines        11539     11539           
  Branches      1743      1743           
=========================================
  Hits         11539     11539

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try looking for some alternative ways to satisfy mypy requirements to no avail - this is probably the best we have for now.

KJhellico
KJhellico approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Oct 17, 2024
Merged via the queue into vacanza:dev with commit 6750bf1 Oct 17, 2024
28 checks passed
@arkid15r arkid15r deleted the satisfy-mypy-requirements branch October 17, 2024 15:19
@KJhellico KJhellico mentioned this pull request Oct 21, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@arkid15r @mstuttgart
Satisfy mypy requirements (vacanza#2053)
6241cfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@PPsyrius PPsyrius PPsyrius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arkid15r @KJhellico @PPsyrius