Update Johor (Malaysia) and United Arab Emirates weekend observance, cleanup others
#2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, cleanup others
|
Need to add here: else:
self._observed_rule = SUN_TO_NEXT_WORKDAY
self.weekend = {SAT, SUN}Then it will work correctly when |
Co-Authored-By: ~Jhellico <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2048 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 11522 11519 -3
Branches 1798 1738 -60
=========================================
- Hits 11522 11519 -3 ☔ View full report in Codecov by Sentry. |
KJhellico
reviewed
Oct 11, 2024
|
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
…, cleanup others (vacanza#2048) Co-authored-by: ~Jhellico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This updates Johor (Malaysia) weekend observance from
FRI-SATback toSAT-SUNas previously used between 1995-2013, starting Jan 1, 2025 next year as decreed on Oct 8, 2024.The same goes for the United Arab Emirates's weekend observance change from
FRI-SATtoSAT-SUNstarting Jan 1, 2022 (we missed this somehow in the last library-wide special weekend implementations).I've also standardised the weekend observance code a bit for other countries to match the existing format used by Saudi Arabia.
Type of change
holidaysfunctionality in general)Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally