Update Singapore holidays: add en_SG, en_US, th localization
#2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2031 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 189 189
Lines 11479 11483 +4
Branches 1795 1795
=========================================
+ Hits 11479 11483 +4 ☔ View full report in Codecov by Sentry. |
I completely agree with en_US standardization! (As I understand, these names, "Hari Raya Puasa" and "Hari Raya Haji", are in fact Malay) |
KJhellico
reviewed
Oct 2, 2024
|
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds English (
en_SG,en_US) and Thai (th) localization for Singapore holidays.I tried to standardize
en_USlocalization to the common Islamic holiday terms used in this library, i.e.Eid al-Fitrinstead ofHari Raya Puasaused inen_SG, so any feedback here would be appreciated.Note
Thai Public Broadcasting Service (Thai PBS) is used as the primary source for Islamic holidays naming over Thai Wikipedia ones i.e.
อีฎิ้ลฟิตริinstead ofอีดิลฟิฏร์Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally