Skip to content

Update Taiwan holidays #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update Taiwan holidays #2026

merged 2 commits into from
Oct 1, 2024

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update Taiwan holidays:

  • fix Children's Day observed calculation
  • add 2025 substituted holiday

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bcd8d88) to head (51eb23c).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2026   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          189       189           
  Lines        11478     11479    +1     
  Branches      1796      1795    -1     
=========================================
+ Hits         11478     11479    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇹🇼

@arkid15r arkid15r enabled auto-merge October 1, 2024 01:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r added this pull request to the merge queue Oct 1, 2024
Merged via the queue into vacanza:dev with commit e36887a Oct 1, 2024
32 checks passed
@KJhellico KJhellico deleted the upd-taiwan branch October 1, 2024 15:34
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@KJhellico @arkid15r @mstuttgart
Update Taiwan holidays (vacanza#2026)
9411c82 
Co-authored-by: Arkadii Yakovets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@PPsyrius PPsyrius PPsyrius left review comments

Assignees

No one assigned

Labels

snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius