Skip to content

Update Australia holidays: fix Christmas Day in ACT #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update Australia holidays: fix Christmas Day in ACT #1986

merged 1 commit into from
Sep 10, 2024
+9 −5

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update Australia holidays: fix Christmas Day in ACT (1958-1991).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner September 10, 2024 16:36
@codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3dfc04a) to head (a764de3).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1986   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11407     11407           
  Branches      1790      1790           
=========================================
  Hits         11407     11407

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r enabled auto-merge September 10, 2024 16:56
arkid15r
arkid15r approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Sep 10, 2024
Merged via the queue into vacanza:dev with commit 7ab98cb Sep 10, 2024
@KJhellico KJhellico deleted the fix-australia branch September 10, 2024 17:29
@arkid15r arkid15r mentioned this pull request Sep 16, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@KJhellico @mstuttgart
Update Australia holidays: fix Christmas Day in ACT (vacanza#1986)
1558cca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

snapshot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KJhellico @arkid15r