Skip to content

Refactor Lao New Year holidays #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2024
Merged

Refactor Lao New Year holidays #1962

merged 4 commits into from
Aug 31, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Aug 29, 2024

Proposed change

Refractor existing Lao New Year holidays logic to better match the official calendars, move the in-lieu observance start from 2018 to 2012 to better match the actual situation.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ec8d56) to head (0eabd6b).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1962   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11419     11422    +3     
  Branches      1795      1799    +4     
=========================================
+ Hits         11419     11422    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico reviewed Aug 30, 2024
View reviewed changes
@KJhellico KJhellico changed the title Refractor Lao New Year holidays Refactor Lao New Year holidays Aug 30, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

arkid15r
arkid15r approved these changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @PPsyrius!

@arkid15r arkid15r added this pull request to the merge queue Aug 31, 2024
Merged via the queue into vacanza:dev with commit 02e10bd Aug 31, 2024
@PPsyrius PPsyrius deleted the refractor_lao_ny_holidays branch September 1, 2024 03:14
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico left review comments

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico