Skip to content

Migrate deprecated Italy subdivisions to subdivision aliases #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2024
Merged

Migrate deprecated Italy subdivisions to subdivision aliases #1951

merged 2 commits into from
Aug 28, 2024

Conversation

@PPsyrius
Copy link
Collaborator

Proposed change

This PR migrates deprecated subdivisions to the new subdivision aliases system, as well as adding full names as alternative aliases for Italian provinces.

Both the ASCII-only and UTF-8 versions of the aliases are available for usability reasons i.e. "Forli-Cesena" and "Forlì-Cesena".

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Aug 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1aede11) to head (8d902be).
Report is 3 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1951   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines        11382     11380    -2     
  Branches      1793      1792    -1     
=========================================
- Hits         11382     11380    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

arkid15r
arkid15r approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇮🇹 LGTM

@arkid15r arkid15r added this pull request to the merge queue Aug 28, 2024
Merged via the queue into vacanza:dev with commit 66bf2df Aug 28, 2024
@PPsyrius PPsyrius deleted the IT_migrate_to_aliases branch August 28, 2024 03:07
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PPsyrius @arkid15r