Migrate deprecated United Kingdom subdivisions to subdivision aliases #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1945 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 187 187
Lines 11397 11391 -6
Branches 1800 1796 -4
=========================================
- Hits 11397 11391 -6 ☔ View full report in Codecov by Sentry. |
|
@PPsyrius, I like these changes. While reviewing it, I got an idea about some tests refactoring. They are too large for suggestions here, so please check PR in your repo. :) |
|
arkid15r
approved these changes
Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR migrates the United Kingdom's deprecated subdivisions to the new subdivision aliases system.
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally