Skip to content

Add automatic snapshots update workflow #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add automatic snapshots update workflow #1939

merged 1 commit into from
Aug 21, 2024

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Aug 21, 2024

Proposed change

Implement automatic snapshots updates

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner August 21, 2024 16:27
@codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e3d0a35) to head (46da8db).
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1939   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines        11316     11316           
  Branches      1789      1789           
=========================================
  Hits         11316     11316

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Aug 21, 2024
Merged via the queue into vacanza:dev with commit 5911905 Aug 21, 2024
@arkid15r arkid15r deleted the add-snapshot-auto-updates branch August 21, 2024 17:56
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @KJhellico