Skip to content

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Aug 9, 2024

Proposed change

Update pre-commit: add bandit

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner August 9, 2024 18:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

@codecov
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ae24041) to head (064259c).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1913   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       185           
  Lines        11263     11263           
  Branches      1785      1785           
=========================================
  Hits         11263     11263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's try it!

@arkid15r arkid15r added this pull request to the merge queue Aug 15, 2024
Merged via the queue into vacanza:dev with commit 1f766e2 Aug 15, 2024
@arkid15r arkid15r deleted the add-bandit branch August 15, 2024 15:20
@arkid15r arkid15r mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants