Skip to content

Update docs: add years example #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2024
Merged

Update docs: add years example #1851

merged 2 commits into from
Jun 30, 2024

Conversation

@arkid15r
Copy link
Collaborator

Proposed change

Add year and year range example.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner June 28, 2024 16:50
@codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2d2d850) to head (69092c2).

❗ Current head 69092c2 differs from pull request most recent head 9a62b64

Please upload reports for the commit 9a62b64 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1851   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       184           
  Lines        11185     11185           
  Branches      1763      1763           
=========================================
  Hits         11185     11185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r linked an issue Jun 28, 2024 that may be closed by this pull request
Documentation for holidays.US(years=array_of_years) ? #1846
Closed
KJhellico
KJhellico reviewed Jun 28, 2024
View reviewed changes
@arkid15r arkid15r enabled auto-merge June 28, 2024 17:57
KJhellico
KJhellico approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Jun 30, 2024
Merged via the queue into vacanza:dev with commit 4d46175 Jun 30, 2024
@arkid15r arkid15r deleted the update-documentation branch June 30, 2024 14:44
@KJhellico KJhellico mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for holidays.US(years=array_of_years) ?

2 participants

@arkid15r @KJhellico