Skip to content

Conversation

@Klintrup
Copy link
Contributor

Proposed change

Add Greenland holidays with Greenlandic, en_US and Danish translations

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@Klintrup
Copy link
Contributor Author

I could not complete the pre-commit/push rules without adding the changes to the CH.po files, if you want I can remove them from the PR and you can push these in another PR.

@Klintrup Klintrup marked this pull request as ready for review May 31, 2024 01:57
@PPsyrius
Copy link
Collaborator

I find "Epiphany" (Jan 6) being listed as Public Holidays too on another source: https://visitgreenland.com/practical-questions/#toggle-id-33 . Can you confirm for me how recent was this added/removed from their list?

A LIST OF PUBLIC HOLIDAYS IN GREENLAND
- 1 Jan New Year’s Day.
- 6 Jan Epiphany (generally a half day of holiday)
- Monday-Thursday (the Thursday before Easter Sunday)
- Good Friday (The Friday before Easter Sunday)
- Easter Sunday (March/April)
- Easter Monday (The day after Easter Sunday)
- General Prayer Day (the fourth Friday after Easter)
- 1 May Labor Day (generally a half day of holiday)
- Ascension Day (40 days after Easter).
- Whit Sunday (seven weeks after Easter).
- Whit Monday (same as above + 1 day)
- [21 Jun National Day.](https://visitgreenland.com/about-greenland/national-day-greenland/)
- 24 Dec Christmas Eve
- 25 Dec First Day of Christmas.
- 26 Dec second Day of Christmas.
- 31 Dec New Year’s Eve.

@Klintrup
Copy link
Contributor Author

I find "Epiphany" (Jan 6) being listed as Public Holidays too on another source: https://visitgreenland.com/practical-questions/#toggle-id-33 . Can you confirm for me how recent was this added/removed from their list?

A LIST OF PUBLIC HOLIDAYS IN GREENLAND
- 1 Jan New Year’s Day.
- 6 Jan Epiphany (generally a half day of holiday)
- Monday-Thursday (the Thursday before Easter Sunday)
- Good Friday (The Friday before Easter Sunday)
- Easter Sunday (March/April)
- Easter Monday (The day after Easter Sunday)
- General Prayer Day (the fourth Friday after Easter)
- 1 May Labor Day (generally a half day of holiday)
- Ascension Day (40 days after Easter).
- Whit Sunday (seven weeks after Easter).
- Whit Monday (same as above + 1 day)
- [21 Jun National Day.](https://visitgreenland.com/about-greenland/national-day-greenland/)
- 24 Dec Christmas Eve
- 25 Dec First Day of Christmas.
- 26 Dec second Day of Christmas.
- 31 Dec New Year’s Eve.

The "Half day" are not official holidays but some union agreements and schools will let parents and kids off on those days, but there is no country-wide agreement on those.

I've found a better list here: https://www.timeanddate.com/holidays/greenland/2024 and will add it as reference along with the Epiphany as an optional holiday.

@arkid15r arkid15r changed the title Add greenland Add Greenland holidays May 31, 2024
@coveralls
Copy link

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build 9321693513

Details

  • 37 of 37 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9320934527: 0.0%
Covered Lines: 11338
Relevant Lines: 11338

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Klintrup, it's just perfect PR! Thank you!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Klintrup thank you for adding Greenland holidays and also for doing it in a clean code fashion!

I could not complete the pre-commit/push rules without adding the changes to the CH.po files, if you want I can remove them from the PR and you can push these in another PR.

Right, this wasn't related to your PR and has been fixed. I updated the PR's code and tests look green.

Optional: would you be willing to update AUTHORS file?

🇬🇱 LGTM

@KJhellico @PPsyrius any comments/suggestions? I hope to include these changes into Monday's v0.50

Thank you!

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Klintrup
Copy link
Contributor Author

@Klintrup thank you for adding Greenland holidays and also for doing it in a clean code fashion!

I could not complete the pre-commit/push rules without adding the changes to the CH.po files, if you want I can remove them from the PR and you can push these in another PR.

Right, this wasn't related to your PR and has been fixed. I updated the PR's code and tests look green.

Optional: would you be willing to update AUTHORS file?

🇬🇱 LGTM

@KJhellico @PPsyrius any comments/suggestions? I hope to include these changes into Monday's v0.50

Thank you!

Thanks for the fix regarding CH.po

I updated the AUTHORS file as requested and implemented your proposed fix to keep the formatting uniform.

@arkid15r arkid15r enabled auto-merge May 31, 2024 17:53
@arkid15r arkid15r added this pull request to the merge queue May 31, 2024
Merged via the queue into vacanza:dev with commit 381c205 May 31, 2024
@Klintrup Klintrup deleted the add-greenland branch May 31, 2024 18:01
@KJhellico KJhellico mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants