-
-
Notifications
You must be signed in to change notification settings - Fork 561
Add Greenland holidays #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Greenland holidays #1811
Conversation
|
I could not complete the pre-commit/push rules without adding the changes to the CH.po files, if you want I can remove them from the PR and you can push these in another PR. |
|
I find "Epiphany" (Jan 6) being listed as Public Holidays too on another source: https://visitgreenland.com/practical-questions/#toggle-id-33 . Can you confirm for me how recent was this added/removed from their list? |
The "Half day" are not official holidays but some union agreements and schools will let parents and kids off on those days, but there is no country-wide agreement on those. I've found a better list here: https://www.timeanddate.com/holidays/greenland/2024 and will add it as reference along with the Epiphany as an optional holiday. |
Pull Request Test Coverage Report for Build 9321693513Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Klintrup, it's just perfect PR! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Klintrup thank you for adding Greenland holidays and also for doing it in a clean code fashion!
I could not complete the pre-commit/push rules without adding the changes to the CH.po files, if you want I can remove them from the PR and you can push these in another PR.
Right, this wasn't related to your PR and has been fixed. I updated the PR's code and tests look green.
Optional: would you be willing to update AUTHORS file?
🇬🇱 LGTM
@KJhellico @PPsyrius any comments/suggestions? I hope to include these changes into Monday's v0.50
Thank you!
|
Thanks for the fix regarding CH.po I updated the AUTHORS file as requested and implemented your proposed fix to keep the formatting uniform. |




Proposed change
Add Greenland holidays with Greenlandic, en_US and Danish translations
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally