-
-
Notifications
You must be signed in to change notification settings - Fork 560
Introduce workdays calculation support #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 8883292282Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, this will make UX more consistent with users' expectations.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Arkadii Yakovets <[email protected]>
|




Proposed change
Introduce workdays related calculation support in Python Holidays. Add following public methods to
HolidayBase:is_workday(dt)- check if date is a working dayget_nth_workday(dt, n)- return n-th working day from dateget_workdays_number(dt1, dt2)- return the number of working days between two datesType of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally