Skip to content

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update Australia holidays: fix Sovereign's Birthday dates in WA.

According to WA Public and Bank Holidays Act 1972, celebration day for the Anniversary of the Birthday of the Reigning Sovereign to be appointed for each year by proclamation published in the Government Gazette (this is usually the last Monday in September, but not always).

Closes #1756.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner April 8, 2024 16:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8603332611

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8602503496: 0.0%
Covered Lines: 11007
Relevant Lines: 11007

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇦🇺 LGTM

@arkid15r arkid15r added this pull request to the merge queue Apr 10, 2024
Merged via the queue into vacanza:dev with commit 894214c Apr 10, 2024
@KJhellico KJhellico deleted the fix-australia-wa branch April 10, 2024 17:17
@arkid15r arkid15r mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update AU holidays: fix WA King's birthday date

3 participants