Skip to content

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

From 2024, the transition date of the Federal Executive Branch will be October 1st, instead of the traditional December 1st.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner March 9, 2024 17:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8215951969

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8207023152: 0.0%
Covered Lines: 10631
Relevant Lines: 10631

💛 - Coveralls

@arkid15r arkid15r enabled auto-merge March 9, 2024 17:11
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇲🇽 LGTM

@arkid15r arkid15r added this pull request to the merge queue Mar 9, 2024
Merged via the queue into vacanza:dev with commit 62b70de Mar 9, 2024
@KJhellico KJhellico deleted the upd-mexico branch March 9, 2024 17:58
@arkid15r arkid15r mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants