Skip to content

Conversation

@PPsyrius
Copy link
Collaborator

Proposed change

Add Seychelles holidays (en_SC, en_US).

Closes #1267.

Note

There's an incomplete list of Seychellois Creole crs translations for holiday names available at https://web.archive.org/web/20240312083508/https://seychellen.com/en/public-holidays/ for future improvement should we decide to implement them at a later date.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8249288462

Details

  • 47 of 47 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8235619848: 0.0%
Covered Lines: 10678
Relevant Lines: 10678

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New country 👍

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PPsyrius PPsyrius requested a review from KJhellico March 12, 2024 13:32
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇸🇨 LGTM

I think you should be able to merge this by clicking "Resolve conversation" on the comment I left.

@arkid15r arkid15r enabled auto-merge March 14, 2024 15:45
@arkid15r arkid15r added this pull request to the merge queue Mar 18, 2024
Merged via the queue into vacanza:dev with commit 0531e43 Mar 18, 2024
@arkid15r arkid15r mentioned this pull request Mar 18, 2024
@PPsyrius PPsyrius deleted the seychelles_holidays branch March 19, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Seychelles holidays

4 participants