Skip to content

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Feb 19, 2024

Proposed change

Resolves #1695

This PR reflects changes related to the recent branch renaming:

  • master -> main
  • beta -> dev

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

  - master -> main
  - beta -> dev
@arkid15r arkid15r requested a review from KJhellico as a code owner February 19, 2024 18:46
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7964020987

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7963965420: 0.0%
Covered Lines: 10547
Relevant Lines: 10547

💛 - Coveralls

@arkid15r arkid15r added this pull request to the merge queue Feb 19, 2024
Merged via the queue into vacanza:dev with commit cc1a50a Feb 19, 2024
@arkid15r arkid15r deleted the rename-branches branch February 19, 2024 18:56
@KJhellico KJhellico mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update branch names

3 participants