Skip to content

Conversation

@PPsyrius
Copy link
Collaborator

Proposed change

This PR fully replace the existing black with ruff as intended in #1671 .

This also restores line length limit to 99 as per outlined in #1297 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PPsyrius
Copy link
Collaborator Author

Turns out the error was from having a wrong branch as a base, gonna close this down from duplication

@PPsyrius PPsyrius closed this Jan 30, 2024
@PPsyrius PPsyrius deleted the restore_char_limit_to_99 branch January 30, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant