-
-
Notifications
You must be signed in to change notification settings - Fork 560
Update Malaysia holidays #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Malaysia holidays #1625
Conversation
Pull Request Test Coverage Report for Build 7505992709
💛 - Coveralls |
|
@shahonseven, thank you for this update. Are there any official sources? |
I'm going to assume that https://www.kabinet.gov.my/bkpp/pdf/hari_kelepasan_am/hka_2024.pdf was used here though that one is inaccessible from Thailand at the moment. Going by a proxy calendar site which refers to that link though - I found some discrepancies for |
Ah sorry it should be 7th, my mistake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We also need to update snapshots. And it would be good to update tests...
|
I've sorted this out. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇲🇾

Proposed change
Update Malaysia holidays
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally