Skip to content

Conversation

@shahonseven
Copy link
Contributor

Proposed change

Update Malaysia holidays

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7505992709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7505622895: 0.0%
Covered Lines: 10273
Relevant Lines: 10273

💛 - Coveralls

@KJhellico
Copy link
Collaborator

@shahonseven, thank you for this update. Are there any official sources?

@PPsyrius
Copy link
Collaborator

PPsyrius commented Jan 5, 2024

@shahonseven, thank you for this update. Are there any official sources?

I'm going to assume that https://www.kabinet.gov.my/bkpp/pdf/hari_kelepasan_am/hka_2024.pdf was used here though that one is inaccessible from Thailand at the moment.

Going by a proxy calendar site which refers to that link though - I found some discrepancies for HIJRI_NEW_YEAR_DATES as that should instead be on Jul 7, with an observance placed on Jul 8:
image

@shahonseven
Copy link
Contributor Author

@shahonseven, thank you for this update. Are there any official sources?

I'm going to assume that https://www.kabinet.gov.my/bkpp/pdf/hari_kelepasan_am/hka_2024.pdf was used here though that one is inaccessible from Thailand at the moment.

Going by a proxy calendar site which refers to that link though - I found some discrepancies for HIJRI_NEW_YEAR_DATES as that should instead be on Jul 7, with an observance placed on Jul 8: image

Ah sorry it should be 7th, my mistake

KJhellico
KJhellico previously approved these changes Jan 5, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We also need to update snapshots. And it would be good to update tests...

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@arkid15r
Copy link
Collaborator

LGTM. We also need to update snapshots. And it would be good to update tests...

I've sorted this out. PTAL.

@arkid15r arkid15r added this pull request to the merge queue Jan 12, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇲🇾

Merged via the queue into vacanza:beta with commit ebd6b66 Jan 12, 2024
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants