Skip to content

Add Papua New Guinea holidays #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 27, 2023
Merged

Add Papua New Guinea holidays #1605

merged 6 commits into from
Dec 27, 2023

Conversation

@PPsyrius
Copy link
Collaborator

Proposed change

Add Papua New Guinea holidays.

Closes #1239 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Dec 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7334395643

  • 45 of 45 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7305483925: 0.0%
Covered Lines: 10298
Relevant Lines: 10298
💛 - Coveralls

@PPsyrius PPsyrius marked this pull request as ready for review December 22, 2023 07:02
KJhellico
KJhellico reviewed Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New countries it's always great! 👍

@PPsyrius PPsyrius requested a review from KJhellico December 23, 2023 09:11
arkid15r
arkid15r reviewed Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 🇵🇬 code looks good, just a few minor comments here:

PPsyrius and others added 2 commits December 27, 2023 09:15
@PPsyrius @arkid15r
[PG] Suggestions 2023Dec17 Pt1
18a30f8 
Co-authored-by: Arkadii Yakovets <[email protected]>
@PPsyrius @arkid15r
[PG] Suggestions 2023Dec17 Pt2
7bfde3c 
Co-Authored-By: Arkadii Yakovets <[email protected]>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PPsyrius PPsyrius requested a review from arkid15r December 27, 2023 02:26
KJhellico
KJhellico reviewed Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r enabled auto-merge December 27, 2023 18:39
@arkid15r arkid15r added this pull request to the merge queue Dec 27, 2023
Merged via the queue into vacanza:beta with commit ff75f24 Dec 27, 2023
@PPsyrius PPsyrius deleted the papua_new_guinea_holidays branch December 28, 2023 03:29
@KJhellico KJhellico mentioned this pull request Jan 1, 2024
Merged
@KJhellico KJhellico mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico left review comments

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Papua New Guinea holidays

4 participants

@PPsyrius @coveralls @arkid15r @KJhellico