Skip to content

Update Singapore 2024 holidays #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update Singapore 2024 holidays #1588

merged 1 commit into from
Dec 8, 2023

Conversation

@KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Dec 8, 2023

Proposed change

Update Singapore holidays in 2024 (according to government source), refactor tests.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner December 8, 2023 17:53
@coveralls
Copy link

coveralls commented Dec 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7144706283

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7144652250: 0.0%
Covered Lines: 10307
Relevant Lines: 10307
💛 - Coveralls

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

arkid15r
arkid15r approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r enabled auto-merge December 8, 2023 19:48
@arkid15r arkid15r added this pull request to the merge queue Dec 8, 2023
Merged via the queue into vacanza:beta with commit 4a67f0a Dec 8, 2023
@arkid15r arkid15r changed the title Update Singapore holidays in 2024 Update Singapore 2024 holidays Dec 8, 2023
@KJhellico KJhellico deleted the upd-singapore branch December 8, 2023 20:16
@arkid15r arkid15r mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @coveralls @arkid15r